Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383AbbL1K5A (ORCPT ); Mon, 28 Dec 2015 05:57:00 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38738 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbbL1Kzs (ORCPT ); Mon, 28 Dec 2015 05:55:48 -0500 Subject: Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver To: Vineet Gupta , Noam Camus References: <1451222619-3610-5-git-send-email-noamc@ezchip.com> <201512272200.4NfpC6DB%fengguang.wu@intel.com> <5680FA14.4010107@linaro.org> <56811074.9020102@synopsys.com> Cc: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Chris Metcalf , "marc.zyngier@arm.com" , Rob Herring , Thomas Gleixner , John Stultz From: Daniel Lezcano Message-ID: <56811530.7070504@linaro.org> Date: Mon, 28 Dec 2015 11:55:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56811074.9020102@synopsys.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2049 Lines: 68 On 12/28/2015 11:35 AM, Vineet Gupta wrote: > On Monday 28 December 2015 02:30 PM, Daniel Lezcano wrote: >>>> reproduce: >>>> # save the attached .config to linux build tree >>>> make ARCH=i386 >>> >>> This is meant for ARC only (not i386), I will add to the Kconfig file a >>> dependency on my platform. >> >> Hi Noam, >> >> for compilation test coverage it would be nice to not restrict the to ARC only but >> change the write_aux_reg to a common name across the different arch if possible. >> >> -- Daniel > > Hi Daniel, > > AUX registers is a ARC specific mechanism used to access some of the core > functionality (intc, caches, ....) which other arches likely do via MMIO. I don't > think a generic abstraction exists. And IMHO it doesn't make sense to invent one > given this may not map directly to other arches. > > This was one of the key reasons arc intc/timers were not added to drivers/* in > first place. > > I do agree with compilation test coverage aspect though. > Maybe we add a *hack* to include/soc/nps/common.h > > #ifndef __ARC__ > #define write_aux_reg(r, v) > #define read_aux_reg(r) 0 > #endif > > What say you ? Yes that's an alternative. Perhaps instead of the __ARC__: /* * Define dummy macros to let different architectures to * compile test some drivers, eg. the timer. */ #ifndef write_aux_reg #define write_aux_reg(r, v) #endif #ifndef read_aux_reg #define read_aux_reg(r) 0 #endif Now that header must be included always *after* asm/arcregs.h. Not sure this kind of implicit ordering is not prone to bug. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/