Date: Mon, 28 Dec 2015 14:39:44 +0000
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Johan Hovold <johan@kernel.org>
Cc: Mathieu OTHACEHE <m.othacehe@gmail.com>, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5] USB: serial: add Moxa UPORT 11x0 driver
Message-ID: <20151228143944.111a6c7f@lxorguk.ukuu.org.uk>
In-Reply-To: <20151228140630.GA18146@localhost>
References: <1449401383-10047-1-git-send-email-m.othacehe@gmail.com>
	<20151228140630.GA18146@localhost>
Organization: Intel Corporation
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1018
Lines: 24

> 	https://lkml.kernel.org/r/201102171210.03474.frode@tennebo.com
> 
> However, the TIOCSRS485-ioctl might not even be the right interface for
> changing transceiver modes, and instead a sysfs-based
> usb-serial-specific interface could be more appropriate for example.

sysfs works out very badly if modes can be configured routinely at
runtime. In particular the sysfs interface is completely disconnected
from the vhangup() and security model of the tty interface.

If its the kind if thing just administratively configured at boot then
it's a great interface, just be careful about who has access to it.


Otherwise the traditional interface for that level of configuration has
probably been termiox, which we do have hooks for but don't really make
much use of.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/