Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbbL1PMo (ORCPT ); Mon, 28 Dec 2015 10:12:44 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:39155 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbbL1PMm (ORCPT ); Mon, 28 Dec 2015 10:12:42 -0500 X-IronPort-AV: E=Sophos;i="5.20,491,1444687200"; d="scan'208";a="194794498" Date: Mon, 28 Dec 2015 16:12:26 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , LKML , kernel-janitors@vger.kernel.org Subject: Re: [media] m88rs6000t: Better exception handling in five functions In-Reply-To: <56814F35.5030103@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <5680FDB3.7060305@users.sourceforge.net> <56810F56.4080306@users.sourceforge.net> <568148FD.7080209@users.sourceforge.net> <5681497E.7030702@users.sourceforge.net> <56814F35.5030103@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 30 On Mon, 28 Dec 2015, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "ret" will not be checked once more > >> after a function call. > > > > This commit message fits with the previous change. > > Do you prefer an other wording? Something like "Split the return into success and error cases, to avoid the need for testing before logging." The concept of the return being duplicated didn't come across in your message. > > It could be nice to put a blank line before the error handling code. > > Is it really a coding style requirement to insert another blank line between > the suggested placement of the statement "return 0;" and the jump label? I don't think it is a requirement. But some files do it, and if other functions in this file do it, then it would be nice to do the same. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/