Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663AbbL1SiJ (ORCPT ); Mon, 28 Dec 2015 13:38:09 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:34936 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbbL1SiG (ORCPT ); Mon, 28 Dec 2015 13:38:06 -0500 MIME-Version: 1.0 In-Reply-To: <20151204082427.GC26902@x1> References: <1448370862-19120-1-git-send-email-lee.jones@linaro.org> <2600153.9u9Z7N2IT1@wuerfel> <20151203172830.GB26902@x1> <2473673.tSymyNlg3h@wuerfel> <20151204082427.GC26902@x1> Date: Mon, 28 Dec 2015 10:38:04 -0800 Message-ID: Subject: Re: [RESEND v4 2/6] remoteproc: debugfs: Add ability to boot remote processor using debugfs From: Bjorn Andersson To: Lee Jones Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Ohad Ben-Cohen , "devicetree@vger.kernel.org" , Florian Fainelli , kernel@stlinux.com, Nathan Lynch , "linux-kernel@vger.kernel.org" , ludovic.barre@st.com, Maxime Coquelin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1347 Lines: 37 On Fri, Dec 4, 2015 at 12:24 AM, Lee Jones wrote: > On Thu, 03 Dec 2015, Arnd Bergmann wrote: > >> On Thursday 03 December 2015 17:28:30 Lee Jones wrote: >> > > >> > > Ah, interesting. I haven't tried myself, and just tried to read the >> > > code. Maybe glibc already catches zero-length writes before it gets >> > > into the kernel, or I just missed the part of the syscall that checks >> > > for this. >> > >> > Glibc is responsible indeed: >> > >> > http://osxr.org/glibc/source/io/write.c >> >> Ok, so an attacker can force the stack overflow by calling >> syscall(__NR_write, fd, p, 0) if that has any potential value, >> but normal users won't hit this case. > > Right. I have fixed the issue (and another one I found) anyway, if > only to rid the GCC warning. > Sorry, but I'm unable to find a new version of this patch, did I miss it or could you resend it? Also, as I looked at this again, we should probably return an error if count >= sizeof(buf) rather than just acknowledging the input (same in the other debugfs write function in this file). Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/