Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbbL1TwY (ORCPT ); Mon, 28 Dec 2015 14:52:24 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36106 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbbL1TwW (ORCPT ); Mon, 28 Dec 2015 14:52:22 -0500 Date: Mon, 28 Dec 2015 20:51:59 +0100 From: Rabin Vincent To: Jens Axboe Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] null_blk: don't enable irqs when in irq Message-ID: <20151228195159.GA5330@debian> References: <1451053594-12188-1-git-send-email-rabin@rab.in> <567E1180.8070004@fb.com> <568184E8.1080801@fb.com> <20151228190715.GA20883@debian> <56818955.8030401@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56818955.8030401@fb.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 25 On Mon, Dec 28, 2015 at 12:11:17PM -0700, Jens Axboe wrote: > On 12/28/2015 12:07 PM, Rabin Vincent wrote: > >On Mon, Dec 28, 2015 at 11:52:24AM -0700, Jens Axboe wrote: > >>Something like this should work, can you test it? > > > >Spits out a bunch of the following. It's this assertion: > > > >static inline void queue_lockdep_assert_held(struct request_queue *q) > >{ > > if (q->queue_lock) > > lockdep_assert_held(q->queue_lock); > >} > > Ah right, we clear the stopped flag. This one should be better. Yes, this one appears to work fine. Tested-by: Rabin Vincent Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/