Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbbL1UJZ (ORCPT ); Mon, 28 Dec 2015 15:09:25 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:6043 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbbL1UJY (ORCPT ); Mon, 28 Dec 2015 15:09:24 -0500 Subject: Re: [PATCH] null_blk: don't enable irqs when in irq To: Rabin Vincent References: <1451053594-12188-1-git-send-email-rabin@rab.in> <567E1180.8070004@fb.com> <568184E8.1080801@fb.com> <20151228190715.GA20883@debian> <56818955.8030401@fb.com> <20151228195159.GA5330@debian> CC: From: Jens Axboe Message-ID: <568196C9.5050903@fb.com> Date: Mon, 28 Dec 2015 13:08:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151228195159.GA5330@debian> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-28_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 30 On 12/28/2015 12:51 PM, Rabin Vincent wrote: > On Mon, Dec 28, 2015 at 12:11:17PM -0700, Jens Axboe wrote: >> On 12/28/2015 12:07 PM, Rabin Vincent wrote: >>> On Mon, Dec 28, 2015 at 11:52:24AM -0700, Jens Axboe wrote: >>>> Something like this should work, can you test it? >>> >>> Spits out a bunch of the following. It's this assertion: >>> >>> static inline void queue_lockdep_assert_held(struct request_queue *q) >>> { >>> if (q->queue_lock) >>> lockdep_assert_held(q->queue_lock); >>> } >> >> Ah right, we clear the stopped flag. This one should be better. > > Yes, this one appears to work fine. > > Tested-by: Rabin Vincent Thanks for testing, I've added it. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/