Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbbL1WPQ (ORCPT ); Mon, 28 Dec 2015 17:15:16 -0500 Received: from spo001.leaseweb.nl ([83.149.101.17]:43961 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752534AbbL1WPM (ORCPT ); Mon, 28 Dec 2015 17:15:12 -0500 Date: Mon, 28 Dec 2015 23:15:10 +0100 From: Wim Van Sebroeck To: Guenter Roeck Cc: linux-watchdog@vger.kernel.org, Damien Riegel , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Message-ID: <20151228221510.GB1889@spo001.leaseweb.nl> References: <1450995724-17758-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450995724-17758-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 23 Hi Guenter, > The 'dev' variable in watchdog drivers has a different lifetime than the > watchdog character device and should therefore not be used by watchdog > drivers. > > Some of the drivers use the variable to print kernel messages. Those > messages are either dropped or changed to use the parent device. > One driver sets the variable during initialization to the watchdog > driver's parent device, which is wrong and was removed. > > v2: Use parent device for dev_XXX messages instead of pr_XXX. This patchset has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/