Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbbL2AFS (ORCPT ); Mon, 28 Dec 2015 19:05:18 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:58796 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752866AbbL2AFQ (ORCPT ); Mon, 28 Dec 2015 19:05:16 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Magnus Damm , iommu@lists.linux-foundation.org, Laurent Pinchart , Geert Uytterhoeven , Linux-sh list , Joerg Roedel , "linux-kernel@vger.kernel.org" , Simon Horman Subject: Re: [PATCH 03/06] iommu/ipmmu-vmsa: Break out utlb control function Date: Tue, 29 Dec 2015 02:05:17 +0200 Message-ID: <1823351.xcsKyrzciK@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.12-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <20151215120212.26216.61530.sendpatchset@little-apple> <20151215120239.26216.43390.sendpatchset@little-apple> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 44 Hi Magnus, On Tuesday 15 December 2015 16:48:42 Geert Uytterhoeven wrote: > On Tue, Dec 15, 2015 at 1:02 PM, Magnus Damm wrote: > > --- 0004/drivers/iommu/ipmmu-vmsa.c > > +++ work/drivers/iommu/ipmmu-vmsa.c 2015-12-15 13:17:40.580513000 > > +0900 > > @@ -279,9 +279,18 @@ static void ipmmu_utlb_enable(struct ipm > > static void ipmmu_utlb_disable(struct ipmmu_vmsa_domain *domain, > > unsigned int utlb) > > { > > - struct ipmmu_vmsa_device *mmu = domain->mmu; > > + ipmmu_write(domain->mmu, IMUCTR(utlb), 0); > > +} > > + > > +static void ipmmu_utlb_ctrl(struct ipmmu_vmsa_domain *domain, > > + void (*fn)(struct ipmmu_vmsa_domain *, > > + unsigned int utlb), struct device > > *dev) > > +{ > > + struct ipmmu_vmsa_dev_data *dev_data = get_dev_data(dev); > > + unsigned int i; > > > > - ipmmu_write(mmu, IMUCTR(utlb), 0); > > + for (i = 0; i < dev_data->num_utlbs; ++i) > > + fn(domain, dev_data->utlbs[i]); > > > > } > > Unless you have further plans with the "fn" parameter, I would simply pass > a bool enable/disable flag instead of a function pointer. I agree with Geert. What's your plan here ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/