Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbbL2Fuc (ORCPT ); Tue, 29 Dec 2015 00:50:32 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:27359 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbbL2Fu3 (ORCPT ); Tue, 29 Dec 2015 00:50:29 -0500 To: CC: , , "Zhaojun (Euler)" , , , From: "Ouyangzhaowei (Charles)" Subject: patch about "don't reset vcpu_info on a cancelled suspend" Message-ID: <56821F02.6050209@huawei.com> Date: Tue, 29 Dec 2015 13:49:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.210] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.56821F13.0036,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4ab257bfa8b325eff88b84ab11dfaf30 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 35 Hi David, This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does it still needs more test to apply to linux kernel? thanks On 2015.5.28 19:07, David Vrabel wrote: >> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu >> >> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(), >> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info >> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle >> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed >> as the cpus can not finish their irqs. >> >> >> Signed-off-by: Charles Ouyang >> Reviewed-by: Boris Ostrovsky >> Reviewed-by: David Vrabel > > 1. I don't think I offered a reviewed-by tag for this patch > 2. You did not Cc the xen-devel mailing list on this patch. > 3. The patch is white-space damaged. > 4. The commit message has lines longer than ~72 chars. > > But I've applied this to for-linus-4.1b anyway, thanks. > > David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/