Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbbL2LkS (ORCPT ); Tue, 29 Dec 2015 06:40:18 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57574 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbbL2LkJ (ORCPT ); Tue, 29 Dec 2015 06:40:09 -0500 Date: Tue, 29 Dec 2015 03:39:58 -0800 From: tip-bot for Laura Abbott Message-ID: Cc: tglx@linutronix.de, labbott@fedoraproject.org, mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org, labbott@fedoraproject.org, tglx@linutronix.de In-Reply-To: <1450728074-31029-1-git-send-email-labbott@fedoraproject.org> References: <1450728074-31029-1-git-send-email-labbott@fedoraproject.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] x86/mm: Drop WARN from multi-BAR check Git-Commit-ID: 9abb0ecdee69a2577560cc283368e490da974934 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2057 Lines: 45 Commit-ID: 9abb0ecdee69a2577560cc283368e490da974934 Gitweb: http://git.kernel.org/tip/9abb0ecdee69a2577560cc283368e490da974934 Author: Laura Abbott AuthorDate: Mon, 21 Dec 2015 12:01:14 -0800 Committer: Thomas Gleixner CommitDate: Tue, 29 Dec 2015 12:34:38 +0100 x86/mm: Drop WARN from multi-BAR check ioremapping multiple BARs produces a warning with a message "Your kernel is fine". This message mostly serves to comfort kernel developers. Users do not read the message, they only see the big scary warning which means something must be horribly broken with their system. Less dramatically, the warn also sets the taint flag which makes it difficult to differentiate problems. If the kernel is actually fine as the warning claims it doesn't make sense for it to be tainted. Change the WARN_ONCE to a pr_warn with the caller of the ioremap. Signed-off-by: Laura Abbott Link: http://lkml.kernel.org/r/1450728074-31029-1-git-send-email-labbott@fedoraproject.org Signed-off-by: Thomas Gleixner --- arch/x86/mm/ioremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index b9c78f3..0d8d53d 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -194,8 +194,8 @@ static void __iomem *__ioremap_caller(resource_size_t phys_addr, * Check if the request spans more than any BAR in the iomem resource * tree. */ - WARN_ONCE(iomem_map_sanity_check(unaligned_phys_addr, unaligned_size), - KERN_INFO "Info: mapping multiple BARs. Your kernel is fine."); + if (iomem_map_sanity_check(unaligned_phys_addr, unaligned_size)) + pr_warn("caller %pS mapping multiple BARs\n", caller); return ret_addr; err_free_area: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/