Date: Tue, 29 Dec 2015 14:54:10 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
cc: LAK <linux-arm-kernel@lists.infradead.org>,
        Huan Wang <alison.wang@nxp.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Huan Wang <alison.wang@freescale.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        John Stultz <john.stultz@linaro.org>,
        Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] arm: kernel: utilize hrtimer based broadcast
In-Reply-To: <4875455.lvoc6XpkZc@wuerfel>
Message-ID: <alpine.DEB.2.11.1512291449380.28591@nanos>
References: <1437124312-44700-1-git-send-email-b18965@freescale.com> <20151027081834.GB1425@svinekod> <DB3PR04MB07407D83CC5F8F5F19A7207F4FB0@DB3PR04MB074.eurprd04.prod.outlook.com> <4875455.lvoc6XpkZc@wuerfel>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2137
Lines: 71

On Mon, 28 Dec 2015, Arnd Bergmann wrote:

> On Monday 28 December 2015 07:18:58 Huan Wang wrote:
> > Hi, Arnd,
> > 
> > 	Could you help to review the following patch? Thanks.
> > 
> 
> Hi Alison,
> 
> I'm sorry but I understand very little of this particular area of the kernel.
> 
> I've added Daniel Lezcano, John Stultz and Thomas Gleixner to Cc, they all
> know this much better than I do and one of them should be able to comment after
> their Christmas break.

I have no real opinion about that patch. It does no harm to unconditionally
setup the hrtimer based broadcast even if it's never used.

Up to the arch maintainer to decide. 

Thanks,

	tglx
 
> > > On Fri, Jul 17, 2015 at 10:11:52AM +0100, Alison Wang wrote:
> > > > Hrtimer based broadcast is used on ARM platform. It can be registered
> > > > as the tick broadcast device in the absence of a real external clock
> > > > device.
> > > >
> > > > Signed-off-by: Alison Wang <alison.wang@freescale.com>
> > > 
> > > This looks sensible to me. FWIW:
> > > 
> > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > > 
> > > Thanks,
> > > Mark.
> > > 
> > > > ---
> > > >  arch/arm/kernel/time.c | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c index
> > > > a66e37e..a9bc73c 100644
> > > > --- a/arch/arm/kernel/time.c
> > > > +++ b/arch/arm/kernel/time.c
> > > > @@ -12,6 +12,7 @@
> > > >   *  reading the RTC at bootup, etc...
> > > >   */
> > > >  #include <linux/clk-provider.h>
> > > > +#include <linux/clockchips.h>
> > > >  #include <linux/clocksource.h>
> > > >  #include <linux/errno.h>
> > > >  #include <linux/export.h>
> > > > @@ -121,5 +122,7 @@ void __init time_init(void)
> > > >  		of_clk_init(NULL);
> > > >  #endif
> > > >  		clocksource_of_init();
> > > > +
> > > > +		tick_setup_hrtimer_broadcast();
> > > >  	}
> > > >  }
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/