Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753770AbbL2S5c (ORCPT ); Tue, 29 Dec 2015 13:57:32 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33404 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600AbbL2S53 (ORCPT ); Tue, 29 Dec 2015 13:57:29 -0500 Date: Tue, 29 Dec 2015 10:57:29 -0800 From: Jeremiah Mahler To: Andrew Morton Cc: Michal Hocko , linux-kernel@vger.kernel.org, Kees Cook , Andy Lutomirski , Will Drewry , Ingo Molnar , Tejun Heo Subject: Re: BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894 Message-ID: <20151229185729.GA2209@hudson.localdomain> Mail-Followup-To: Jeremiah Mahler , Andrew Morton , Michal Hocko , linux-kernel@vger.kernel.org, Kees Cook , Andy Lutomirski , Will Drewry , Ingo Molnar , Tejun Heo References: <20151224171253.GA3148@hudson.localdomain> <20151229162346.GB10321@dhcp22.suse.cz> <20151229103037.68d1643d.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151229103037.68d1643d.akpm@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 51 Andrew, Michal, On Tue, Dec 29, 2015 at 10:30:37AM -0800, Andrew Morton wrote: > On Tue, 29 Dec 2015 17:23:47 +0100 Michal Hocko wrote: > > > [CCing Andrew] > > > > On Thu 24-12-15 09:12:53, Jeremiah Mahler wrote: > > > all, > > > > > > I have started seeing a "Bad rss-counter" message in the logs with > > > the latest linux-next 20151222+. > > > > > > [ 458.282192] BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894 > > > > This is MM_SHMEMPAGES so an "unamapped" shmem memory. One possible > > reason might be an unitialized zap_details used from unmap_mapping_range > > during truncate introduced by "mm, oom: introduce oom reaper" from the > > mmotm tree. There is a fix for this which is still pending > > http://lkml.kernel.org/r/1450487091-7822-1-git-send-email-sasha.levin%40oracle.com > > That won't be getting fixed until linux-next returns from holidays. > > This: > > --- a/mm/memory.c~mm-oom-introduce-oom-reaper-fix-5-fix > +++ a/mm/memory.c > @@ -2415,7 +2415,7 @@ static inline void unmap_mapping_range_t > void unmap_mapping_range(struct address_space *mapping, > loff_t const holebegin, loff_t const holelen, int even_cows) > { > - struct zap_details details; > + struct zap_details details = { }; > pgoff_t hba = holebegin >> PAGE_SHIFT; > pgoff_t hlen = (holelen + PAGE_SIZE - 1) >> PAGE_SHIFT; > > _ > I tested both the patch that Michal mentioned as well as the change that Andrew provided. The both appear to fix the problem on my machine. Thanks for the help :-) -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/