Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753938AbbL2TLV (ORCPT ); Tue, 29 Dec 2015 14:11:21 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33024 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753904AbbL2TLP (ORCPT ); Tue, 29 Dec 2015 14:11:15 -0500 Date: Tue, 29 Dec 2015 13:11:12 -0600 From: Andy Gross To: Bjorn Andersson Cc: Eugene Krasnikov , Ian Campbell , Kalle Valo , Mark Rutland , Pawel Moll , Rob Herring , devicetree@vger.kernel.org, fengwei.yin@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, wcn36xx@lists.infradead.org Subject: Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Message-ID: <20151229191112.GB27812@hector.attlocal.net> References: <1451266467-15377-1-git-send-email-bjorn.andersson@sonymobile.com> <1451266467-15377-5-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451266467-15377-5-git-send-email-bjorn.andersson@sonymobile.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 35 On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > Signed-off-by: Bjorn Andersson > --- > + > +- qcom,wcnss-mmio: > + Usage: required > + Value type: nit: encoded > + Definition: should specify base address and size of the WiFi related > + registers of WCNSS > + > +- qcom,state: > + Usage: required > + Value type: > + Definition: should specify the tx-enable and tx-ring-empty state > + references > + Otherwise looks good. Reviewed-by: Andy Gross -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/