Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbbL2UIt (ORCPT ); Tue, 29 Dec 2015 15:08:49 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:59862 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753712AbbL2UIp (ORCPT ); Tue, 29 Dec 2015 15:08:45 -0500 Date: Tue, 29 Dec 2015 15:08:43 -0500 (EST) Message-Id: <20151229.150843.2021692616139434395.davem@davemloft.net> To: rweikusat@mobileactivedefense.com Cc: jacob@teenage.engineering, netdev@vger.kernel.org, herbert@gondor.apana.org.au, edumazet@google.com, khlebnikov@yandex-team.ru, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram From: David Miller In-Reply-To: <87y4cdyrbn.fsf@doppelsaurus.mobileactivedefense.com> References: <1451416224-15871-1-git-send-email-jacob@teenage.engineering> <87y4cdyrbn.fsf@doppelsaurus.mobileactivedefense.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Dec 2015 12:08:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 19 From: Rainer Weikusat Date: Tue, 29 Dec 2015 19:42:36 +0000 > Jacob Siverskog writes: >> This should fix a NULL pointer dereference I encountered (dump >> below). Since __skb_unlink is called while walking, >> skb_queue_walk_safe should be used. > > The code in question is: ... > __skb_unlink is only called prior to returning from the function. > Consequently, it won't affect the skb_queue_walk code. Agreed, this patch doesn't fix anything. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/