Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbbL2UOJ (ORCPT ); Tue, 29 Dec 2015 15:14:09 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:59909 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753689AbbL2UOH (ORCPT ); Tue, 29 Dec 2015 15:14:07 -0500 Date: Tue, 29 Dec 2015 15:14:05 -0500 (EST) Message-Id: <20151229.151405.518049202533460569.davem@davemloft.net> To: tom.leiming@gmail.com Cc: linux-kernel@vger.kernel.org, ast@kernel.org, netdev@vger.kernel.org, daniel@iogearbox.net Subject: Re: [PATCH v2 0/3] bpf: hash: use per-bucket spinlock From: David Miller In-Reply-To: <1451400027-28892-1-git-send-email-tom.leiming@gmail.com> References: <1451400027-28892-1-git-send-email-tom.leiming@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Dec 2015 12:14:07 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 32 From: Ming Lei Date: Tue, 29 Dec 2015 22:40:24 +0800 > Hi, > > This patchset tries to optimize ebpf hash map, and follows > the idea: > > Both htab_map_update_elem() and htab_map_delete_elem() > can be called from eBPF program, and they may be in kernel > hot path, it isn't efficient to use a per-hashtable lock > in this two helpers, so this patch converts the lock into > per-bucket spinlock. > > With this patchset, looks the performance penalty from eBPF > decreased a lot, see the following test: > > 1) run 'tools/biolatency' of bcc before running block test; > > 2) run fio to test block throught over /dev/nullb0, > (randread, 16jobs, libaio, 4k bs) and the test box > is one 24cores(dual sockets) VM server: > - without patchset: 607K IOPS > - with this patchset: 1184K IOPS > - without running eBPF prog: 1492K IOPS Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/