Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753968AbbL2U72 (ORCPT ); Tue, 29 Dec 2015 15:59:28 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:38052 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753689AbbL2U70 (ORCPT ); Tue, 29 Dec 2015 15:59:26 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 29 Dec 2015 15:59:26 -0500 X-Google-Sender-Auth: L3zS0a5dWo10bZvXlJRTQPOPMUs Message-ID: Subject: Re: [PATCH 3/5] Staging: panel: Remove ULL From: Ilia Mirkin To: Ksenija Stanojevic Cc: Greg Kroah-Hartman , willy@meta-x.org, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1832 Lines: 57 On Tue, Dec 29, 2015 at 3:08 PM, Ksenija Stanojevic wrote: > Remove ULL since it's useless. > > Signed-off-by: Ksenija Stanojevic > --- > drivers/staging/panel/panel.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > index 7138ee7..6dc3efb 100644 > --- a/drivers/staging/panel/panel.c > +++ b/drivers/staging/panel/panel.c > @@ -2047,10 +2047,10 @@ static u8 input_name2mask(const char *name, __u64 *mask, __u64 *value, > u8 im, om; > __u64 m, v; > > - om = 0ULL; > - im = 0ULL; > - m = 0ULL; > - v = 0ULL; > + om = 0; > + im = 0; > + m = 0; > + v = 0; > while (*name) { > int in, out, bit, neg; > > @@ -2076,9 +2076,9 @@ static u8 input_name2mask(const char *name, __u64 *mask, __u64 *value, > > bit = (out * 5) + in; > > - m |= 1ULL << bit; > + m |= 1 << bit; m and v are 64-bit, if bit can be >= 32, then you definitely do need the ULL here... > if (!neg) > - v |= 1ULL << bit; > + v |= 1 << bit; > name++; > } > *mask = m; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/