Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753999AbbL2VjF (ORCPT ); Tue, 29 Dec 2015 16:39:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57168 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbbL2Viq (ORCPT ); Tue, 29 Dec 2015 16:38:46 -0500 Date: Tue, 29 Dec 2015 13:38:44 -0800 From: Andrew Morton To: Gang He Cc: mfasheh@suse.com, rgoldwyn@suse.de, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Message-Id: <20151229133844.b2758dbe21604e64acd50383@linux-foundation.org> In-Reply-To: <1451027779-6849-2-git-send-email-ghe@suse.com> References: <1451027779-6849-1-git-send-email-ghe@suse.com> <1451027779-6849-2-git-send-email-ghe@suse.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 26 On Fri, 25 Dec 2015 15:16:16 +0800 Gang He wrote: > Export ocfs2_kset object from ocfs2_stackglue kernel module, > then online file check code will create the related sysfiles > under ocfs2_kset object. > > ... > > --- a/fs/ocfs2/stackglue.c > +++ b/fs/ocfs2/stackglue.c > @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = { > .attrs = ocfs2_attrs, > }; > > -static struct kset *ocfs2_kset; > +struct kset *ocfs2_kset; > +EXPORT_SYMBOL_GPL(ocfs2_kset); The EXPORT_SYMBOL is only needed if this symbol is to be referred to from a different module. That isn't the case here - everything which refers to ocfs2_kset is linked into ocfs2.ko, correct? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/