Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbbL2V4L (ORCPT ); Tue, 29 Dec 2015 16:56:11 -0500 Received: from mail.kernel.org ([198.145.29.136]:48718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbbL2V4I convert rfc822-to-8bit (ORCPT ); Tue, 29 Dec 2015 16:56:08 -0500 MIME-Version: 1.0 In-Reply-To: <1451424412.13576.1.camel@collins> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-5-git-send-email-contact@paulk.fr> <20151229200244.GA27426@rob-hp-laptop> <1451424412.13576.1.camel@collins> From: Rob Herring Date: Tue, 29 Dec 2015 15:55:45 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support To: Paul Kocialkowski Cc: "linux-kernel@vger.kernel.org" , Mark Rutland , Milo Kim , Russell King , Pawel Moll , Ian Campbell , Tony Lindgren , Mark Brown , Liam Girdwood , "devicetree@vger.kernel.org" , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Kumar Gala , linux-omap , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1971 Lines: 40 On Tue, Dec 29, 2015 at 3:26 PM, Paul Kocialkowski wrote: > Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : >> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: >> > LP872x regulators are made active via the EN pin, which might be hooked to a >> > GPIO. This adds support for driving the GPIO high when the driver is in use. >> > >> > Signed-off-by: Paul Kocialkowski >> > --- >> > .../devicetree/bindings/regulator/lp872x.txt | 1 + >> > drivers/regulator/lp872x.c | 33 ++++++++++++++++++++-- >> > include/linux/regulator/lp872x.h | 2 ++ >> > 3 files changed, 33 insertions(+), 3 deletions(-) >> > >> > diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt >> > index 7818318..0559c25 100644 >> > --- a/Documentation/devicetree/bindings/regulator/lp872x.txt >> > +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt >> > @@ -28,6 +28,7 @@ Optional properties: >> > - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices. >> > - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2. >> > - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH. >> > + - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices. >> >> Should be "-gpios" instead of "-gpio". > > Care to comment why? There is only one GPIO that can be used here, since > there is only one single EN pin. I thought this matched what is done > already with "ti,dvs-gpio". To be consistent. We use "clocks" and "interrupts" always whether one or more for example. -gpio is documented as deprecated now. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/