Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754091AbbL3DAN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Dec 2015 22:00:13 -0500
Received: from relay2.provo.novell.com ([137.65.250.214]:60605 "EHLO
	relay2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752158AbbL3DAL convert rfc822-to-8bit (ORCPT
	<rfc822;groupwise-linux-kernel@vger.kernel.org:5:1>);
	Tue, 29 Dec 2015 22:00:11 -0500
Message-Id: <5683B938020000F900023B48@relay2.provo.novell.com>
X-Mailer: Novell GroupWise Internet Agent 14.2.0 
Date: Tue, 29 Dec 2015 20:00:08 -0700
From: "Gang He" <ghe@suse.com>
To: <akpm@linux-foundation.org>
Cc: <ocfs2-devel@oss.oracle.com>, "Mark Fasheh" <MFasheh@suse.com>,
        <rgoldwyn@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] Add online file check feature
References: <1451027779-6849-1-git-send-email-ghe@suse.com>
 <20151229134111.6e0817e4b540c1fdf42d0475@linux-foundation.org>
In-Reply-To: <20151229134111.6e0817e4b540c1fdf42d0475@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2011
Lines: 45

Hello Andrew  and Mark,


>>> 
> On Fri, 25 Dec 2015 15:16:15 +0800 Gang He <ghe@suse.com> wrote:
> 
>> When there are errors in the ocfs2 filesystem,
>> they are usually accompanied by the inode number which caused the error.
>> This inode number would be the input to fixing the file.
>> One of these options could be considered:
>> A file in the sys filesytem which would accept inode numbers.
>> This could be used to communication back what has to be fixed or is fixed.
>> You could write:
>> $# echo "<inode>" > /sys/fs/ocfs2/devname/filecheck/check
>> or
>> $# echo "<inode>" > /sys/fs/ocfs2/devname/filecheck/fix
>> 
>> Compare with second version, I re-design filecheck sysfs interfaces, there
>> are three sysfs files(check, fix and set) under filecheck directory(see 
> above),
>> sysfs will accept only one argument <inode>. Second, I adjust some code in 
>> ocfs2_filecheck_repair_inode_block() function according to upstream 
> feedback,
>> we cannot just add VALID_FL flag back as a inode block fix, then we will not 
> 
>> fix this field corruption currently until having a complete solution.
>> Compare with first version, I use strncasecmp instead of double strncmp
>> functions. Second, update the source file contribution vendor.
>  
> This feature should be documented, please.  That means all pseudo-file
> locations, all inputs, all outputs, expected behaviour etc etc.  Enough
> info so that our users can usefully and fully use this feature in the
> minimum time.  Documentation/filesystems/ocfs2.txt is the place for that.
I ever sent out a document which describes this feature, I will modify that document sightly since sysfs interfaces have been adjusted,
then send out to the list as a separated patch. Is it OK for you?

Thanks
Gang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/