Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbbL3Eyb (ORCPT ); Tue, 29 Dec 2015 23:54:31 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33127 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754096AbbL3Ey3 (ORCPT ); Tue, 29 Dec 2015 23:54:29 -0500 From: Joshua Clayton To: Sudip Mukherjee Cc: Andrew Morton , devel@driverdev.osuosl.org, Andreas Dilger , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Oleg Drokin , linux-mm@kvack.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE() Date: Tue, 29 Dec 2015 20:54:23 -0800 Message-ID: <2084563.z85RFGy3ri@diplodocus> User-Agent: KMail/4.14.10 (Linux/4.3.3-gentoo; KDE/4.14.15; x86_64; ; ) In-Reply-To: <20151230044750.GA18675@sudip-pc> References: <1451193162-20057-1-git-send-email-stillcompiling@gmail.com> <20151230044750.GA18675@sudip-pc> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 22 On Wednesday, December 30, 2015 10:17:50 AM Sudip Mukherjee wrote: > On Sat, Dec 26, 2015 at 09:12:42PM -0800, Joshua Clayton wrote: > > running sparse on drivers/staging/lustre results in dozens of warnings: > > include/linux/gfp.h:281:41: warning: > > odd constant _Bool cast (400000 becomes 1) > > > > Use "!!" to explicitly convert the result to bool range. > > --- > > Signed-off-by missing. > > regards > sudip Hmm. I must have forgotten the "-s" in git send-email I'm thinking a patch this size wouldn't qualify for copyright even if an Oracle Lawyer claimed it. Nevertheless, all is well. The SOB made it into v2. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/