Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374AbbL3GNh (ORCPT ); Wed, 30 Dec 2015 01:13:37 -0500 Received: from relay2.provo.novell.com ([137.65.250.214]:34540 "EHLO relay2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbbL3GNd convert rfc822-to-8bit (ORCPT ); Wed, 30 Dec 2015 01:13:33 -0500 Message-Id: <5683E68B020000F900023B73@relay2.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Tue, 29 Dec 2015 23:13:31 -0700 From: "Gang He" To: Cc: , "Mark Fasheh" , , Subject: Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check References: <1451027779-6849-1-git-send-email-ghe@suse.com> <1451027779-6849-2-git-send-email-ghe@suse.com> <20151229133844.b2758dbe21604e64acd50383@linux-foundation.org> In-Reply-To: <20151229133844.b2758dbe21604e64acd50383@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 37 Hello Andrew, >>> > On Fri, 25 Dec 2015 15:16:16 +0800 Gang He wrote: > >> Export ocfs2_kset object from ocfs2_stackglue kernel module, >> then online file check code will create the related sysfiles >> under ocfs2_kset object. >> >> ... >> >> --- a/fs/ocfs2/stackglue.c >> +++ b/fs/ocfs2/stackglue.c >> @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = { >> .attrs = ocfs2_attrs, >> }; >> >> -static struct kset *ocfs2_kset; >> +struct kset *ocfs2_kset; >> +EXPORT_SYMBOL_GPL(ocfs2_kset); > > The EXPORT_SYMBOL is only needed if this symbol is to be referred to > from a different module. That isn't the case here - everything which > refers to ocfs2_kset is linked into ocfs2.ko, correct? There are some kernel modules (Not single KO file) for OCFS2 file system, the variable ocfs2_kset is located in ocfs2_stackglue.ko kernel module, if the main kernel module ocfs2.ko wants to refer to this variable, it looks to have to export this symbol? Thanks Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/