Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754310AbbL3JCV (ORCPT ); Wed, 30 Dec 2015 04:02:21 -0500 Received: from mail-vk0-f41.google.com ([209.85.213.41]:36040 "EHLO mail-vk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbbL3JCP (ORCPT ); Wed, 30 Dec 2015 04:02:15 -0500 MIME-Version: 1.0 In-Reply-To: <1451457706-14798-5-git-send-email-jamesjj.liao@mediatek.com> References: <1451457706-14798-1-git-send-email-jamesjj.liao@mediatek.com> <1451457706-14798-5-git-send-email-jamesjj.liao@mediatek.com> From: Daniel Kurtz Date: Wed, 30 Dec 2015 17:01:54 +0800 X-Google-Sender-Auth: gtIstsOz6Ja7xPS2cxkq70A8A7w Message-ID: Subject: Re: [PATCH 4/4] soc: mediatek: Add MT2701/MT7623 scpsys driver To: James Liao Cc: Matthias Brugger , Sascha Hauer , Kevin Hilman , srv_heupstream , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Shunli Wang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 45 On Wed, Dec 30, 2015 at 2:41 PM, James Liao wrote: > > From: Shunli Wang > > Add scpsys driver for MT2701 and MT7623. > > Signed-off-by: Shunli Wang > Signed-off-by: James Liao > --- > drivers/soc/mediatek/Kconfig | 11 +++ > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mtk-scpsys-mt2701.c | 161 +++++++++++++++++++++++++++++++ > 3 files changed, 173 insertions(+) > create mode 100644 drivers/soc/mediatek/mtk-scpsys-mt2701.c > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index eca6fb7..92cf838 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -39,3 +39,14 @@ config MTK_SCPSYS_MT8173 > driver. > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. > + > +config MTK_SCPSYS_MT2701 > + bool "SCPSYS Support MediaTek MT2701 and MT7623" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + select MTK_SCPSYS > + default ARCH_MEDIATEK > + help > + Say yes here to add support for the MT2701/MT7623 SCPSYS power > + domain driver. > + The System Control Processor System (SCPSYS) has several power > + management related tasks in the system. I don't think we really want different drivers and Kconfig options. Can we just use different compatibles to select the appropriate scp_domain_data? -Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/