Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbbL3KNp (ORCPT ); Wed, 30 Dec 2015 05:13:45 -0500 Received: from mail-io0-f177.google.com ([209.85.223.177]:36002 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175AbbL3KNk (ORCPT ); Wed, 30 Dec 2015 05:13:40 -0500 MIME-Version: 1.0 In-Reply-To: <20151230050135.GA20277@sudip-pc> References: <5a2ef40d14f83d2917f1f125aed721a076292662.1451214623.git.ksenija.stanojevic@gmail.com> <20151230050135.GA20277@sudip-pc> Date: Wed, 30 Dec 2015 11:13:40 +0100 Message-ID: Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters From: =?UTF-8?Q?Ksenija_Stanojevi=C4=87?= To: Sudip Mukherjee Cc: willy@meta-x.org, devel@driverdev.osuosl.org, Greg KH , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 35 On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee wrote: > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: >> Split comment in order to fit into 80 characters per line. >> Found by checkpatch.pl >> >> Signed-off-by: Ksenija Stanojevic >> --- > > Instead of multiline maybe this is better: > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > index 79ac192..3525919 100644 > --- a/drivers/staging/panel/panel.c > +++ b/drivers/staging/panel/panel.c > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void) > lcd_send_serial(0x5F); /* R/W=W, RS=1 */ > lcd_send_serial(' ' & 0x0F); > lcd_send_serial((' ' >> 4) & 0x0F); > - usleep_range(40, 100); /* the shortest data takes at least 40 us */ > + /* the shortest data takes at least 40 us */ > + usleep_range(40, 100); > } > spin_unlock_irq(&pprt_lock); It's already been done by Bijosh Thykkoottathil: https://lkml.org/lkml/2015/12/18/681 Regards, Ksenija -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/