Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577AbbL3KSU (ORCPT ); Wed, 30 Dec 2015 05:18:20 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:40842 "EHLO mailgw02.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754525AbbL3KSQ (ORCPT ); Wed, 30 Dec 2015 05:18:16 -0500 X-Listener-Flag: 11101 Message-ID: <1451470692.22426.11.camel@mtksdaap41> Subject: Re: [PATCH 4/4] soc: mediatek: Add MT2701/MT7623 scpsys driver From: James Liao To: Daniel Kurtz CC: Matthias Brugger , Sascha Hauer , Kevin Hilman , srv_heupstream , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Shunli Wang Date: Wed, 30 Dec 2015 18:18:12 +0800 In-Reply-To: References: <1451457706-14798-1-git-send-email-jamesjj.liao@mediatek.com> <1451457706-14798-5-git-send-email-jamesjj.liao@mediatek.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2262 Lines: 60 Hi Daniel, On Wed, 2015-12-30 at 17:01 +0800, Daniel Kurtz wrote: > On Wed, Dec 30, 2015 at 2:41 PM, James Liao wrote: > > > > From: Shunli Wang > > > > Add scpsys driver for MT2701 and MT7623. > > > > Signed-off-by: Shunli Wang > > Signed-off-by: James Liao > > --- > > drivers/soc/mediatek/Kconfig | 11 +++ > > drivers/soc/mediatek/Makefile | 1 + > > drivers/soc/mediatek/mtk-scpsys-mt2701.c | 161 +++++++++++++++++++++++++++++++ > > 3 files changed, 173 insertions(+) > > create mode 100644 drivers/soc/mediatek/mtk-scpsys-mt2701.c > > > > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > > index eca6fb7..92cf838 100644 > > --- a/drivers/soc/mediatek/Kconfig > > +++ b/drivers/soc/mediatek/Kconfig > > @@ -39,3 +39,14 @@ config MTK_SCPSYS_MT8173 > > driver. > > The System Control Processor System (SCPSYS) has several power > > management related tasks in the system. > > + > > +config MTK_SCPSYS_MT2701 > > + bool "SCPSYS Support MediaTek MT2701 and MT7623" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + select MTK_SCPSYS > > + default ARCH_MEDIATEK > > + help > > + Say yes here to add support for the MT2701/MT7623 SCPSYS power > > + domain driver. > > + The System Control Processor System (SCPSYS) has several power > > + management related tasks in the system. > > I don't think we really want different drivers and Kconfig options. > > Can we just use different compatibles to select the appropriate scp_domain_data? Yes, we can. All scpsys drivers are built-in by default, and they will be activate by specific compatible string. But some projects don't want to build unused drivers into kernel to save code size. Use different Kconfig options for each SoC so that these projects can disable unused drivers. Best regards, James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/