Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754624AbbL3K4l (ORCPT ); Wed, 30 Dec 2015 05:56:41 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34467 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754309AbbL3K4i (ORCPT ); Wed, 30 Dec 2015 05:56:38 -0500 Subject: Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused To: Heinrich Schuchardt , "David S. Miller" References: <1451427722-2672-1-git-send-email-xypron.glpk@gmx.de> Cc: mtk.manpages@gmail.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org From: "Michael Kerrisk (man-pages)" Message-ID: <5683B863.9010506@gmail.com> Date: Wed, 30 Dec 2015 11:56:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1451427722-2672-1-git-send-email-xypron.glpk@gmx.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 45 Hi Heinrich, On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. Can you say something about how you confirmed this? It's not immediately obvious from the code. Cheers, Michael > Signed-off-by: Heinrich Schuchardt > --- > include/uapi/linux/sockios.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h > index e888b1a..8e7890b 100644 > --- a/include/uapi/linux/sockios.h > +++ b/include/uapi/linux/sockios.h > @@ -27,7 +27,7 @@ > /* Routing table calls. */ > #define SIOCADDRT 0x890B /* add routing table entry */ > #define SIOCDELRT 0x890C /* delete routing table entry */ > -#define SIOCRTMSG 0x890D /* call to routing system */ > +#define SIOCRTMSG 0x890D /* unused */ > > /* Socket configuration controls. */ > #define SIOCGIFNAME 0x8910 /* get iface name */ > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/