Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701AbbL3LcX (ORCPT ); Wed, 30 Dec 2015 06:32:23 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36860 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbbL3LcO (ORCPT ); Wed, 30 Dec 2015 06:32:14 -0500 Date: Wed, 30 Dec 2015 17:02:03 +0530 From: Sudip Mukherjee To: Ksenija =?utf-8?Q?Stanojevi=C4=87?= Cc: willy@meta-x.org, devel@driverdev.osuosl.org, Greg KH , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters Message-ID: <20151230113203.GA30551@sudip-pc> References: <5a2ef40d14f83d2917f1f125aed721a076292662.1451214623.git.ksenija.stanojevic@gmail.com> <20151230050135.GA20277@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 40 On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote: > On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee > wrote: > > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: > >> Split comment in order to fit into 80 characters per line. > >> Found by checkpatch.pl > >> > >> Signed-off-by: Ksenija Stanojevic > >> --- > > > > Instead of multiline maybe this is better: > > > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > > index 79ac192..3525919 100644 > > --- a/drivers/staging/panel/panel.c > > +++ b/drivers/staging/panel/panel.c > > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void) > > lcd_send_serial(0x5F); /* R/W=W, RS=1 */ > > lcd_send_serial(' ' & 0x0F); > > lcd_send_serial((' ' >> 4) & 0x0F); > > - usleep_range(40, 100); /* the shortest data takes at least 40 us */ > > + /* the shortest data takes at least 40 us */ > > + usleep_range(40, 100); > > } > > spin_unlock_irq(&pprt_lock); > > It's already been done by Bijosh Thykkoottathil: > https://lkml.org/lkml/2015/12/18/681 But I think not yet accepted by Greg. And his commit message doesnot mention what coding style errors he has fixed. Usually Greg will not accept them. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/