Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813AbbL3NXW (ORCPT ); Wed, 30 Dec 2015 08:23:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35018 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754022AbbL3NXS (ORCPT ); Wed, 30 Dec 2015 08:23:18 -0500 Subject: Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction To: Christopher Covington , Andy Shevchenko References: <1449677909-12432-1-git-send-email-okaya@codeaurora.org> <1449677909-12432-2-git-send-email-okaya@codeaurora.org> <56686037.70109@codeaurora.org> <56686171.5060102@codeaurora.org> Cc: "linux-acpi@vger.kernel.org" , Timur Tabi , jcm@redhat.com, helgaas@kernel.org, "Rafael J. Wysocki" , Len Brown , "linux-kernel@vger.kernel.org" From: Sinan Kaya Message-ID: <5683DAD3.4080006@codeaurora.org> Date: Wed, 30 Dec 2015 08:23:31 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56686171.5060102@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1880 Lines: 51 Hi Bjorn, Andy; On 12/9/2015 12:14 PM, Christopher Covington wrote: > Hi Sinan, > > On 12/09/2015 12:09 PM, Sinan Kaya wrote: >> On 12/9/2015 11:59 AM, Andy Shevchenko wrote: >>>> + if (trigger != ACPI_MADT_TRIGGER_LEVEL || >>>>> + polarity != ACPI_MADT_POLARITY_ACTIVE_LOW) >>>>> + penalty = PIRQ_PENALTY_ISA_ALWAYS; >>>>> + else >>>>> + penalty = PIRQ_PENALTY_PCI_USING; >>>>> + >>>>> + acpi_irq_add_penalty(irq, penalty); >>> Why not to change in place? I think a common sense rule is not to >>> change something existing if it doesn't add any significant value. >>> >> Sorry, I didn't understand what you mean. Are you asking why we are >> changing lines like above? >> >> If yes, acpi_irq_penalty used to be an array of 256 entries. Now, >> acpi_irq_penalty doesn't exist anymore as it was replaced with a linklist. >> >>> - acpi_irq_penalty[irq] += PIRQ_PENALTY_PCI_USING; >>> + acpi_irq_add_penalty(irq, PIRQ_PENALTY_PCI_USING); > > I think Andy was suggesting that you make the change without introducing > the penalty variable. > > Christopher Covington > Andy, Is Chris' interpretation correct? BTW, I suggest you spend some time around checkpatch for contributions. I could have caught most of the issues you are generally concerned before submitting a patch. Bjorn, Is there any other question you need me to address on this patch? -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/