Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176AbbL3N2a (ORCPT ); Wed, 30 Dec 2015 08:28:30 -0500 Received: from mail-yk0-f181.google.com ([209.85.160.181]:35147 "EHLO mail-yk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755114AbbL3N2Z (ORCPT ); Wed, 30 Dec 2015 08:28:25 -0500 MIME-Version: 1.0 In-Reply-To: <5683DAD3.4080006@codeaurora.org> References: <1449677909-12432-1-git-send-email-okaya@codeaurora.org> <1449677909-12432-2-git-send-email-okaya@codeaurora.org> <56686037.70109@codeaurora.org> <56686171.5060102@codeaurora.org> <5683DAD3.4080006@codeaurora.org> Date: Wed, 30 Dec 2015 15:28:24 +0200 Message-ID: Subject: Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction From: Andy Shevchenko To: Sinan Kaya Cc: Christopher Covington , "linux-acpi@vger.kernel.org" , Timur Tabi , jcm@redhat.com, helgaas@kernel.org, "Rafael J. Wysocki" , Len Brown , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 38 On Wed, Dec 30, 2015 at 3:23 PM, Sinan Kaya wrote: > On 12/9/2015 12:14 PM, Christopher Covington wrote: >>> On 12/9/2015 11:59 AM, Andy Shevchenko wrote: >>>>> + if (trigger != ACPI_MADT_TRIGGER_LEVEL || >>>>>> + polarity != ACPI_MADT_POLARITY_ACTIVE_LOW) >>>>>> + penalty = PIRQ_PENALTY_ISA_ALWAYS; >>>>>> + else >>>>>> + penalty = PIRQ_PENALTY_PCI_USING; >>>>>> + >>>>>> + acpi_irq_add_penalty(irq, penalty); >>>> Why not to change in place? I think a common sense rule is not to >>>> change something existing if it doesn't add any significant value. >>>> - acpi_irq_penalty[irq] += PIRQ_PENALTY_PCI_USING; >>>> + acpi_irq_add_penalty(irq, PIRQ_PENALTY_PCI_USING); >> >> I think Andy was suggesting that you make the change without introducing >> the penalty variable. > Is Chris' interpretation correct? Yep, I meant not to use an additional variable. > BTW, I suggest you spend some time around checkpatch for contributions. I could > have caught most of the issues you are generally concerned before submitting a patch. Is it a question? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/