Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbbL3OVF (ORCPT ); Wed, 30 Dec 2015 09:21:05 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36732 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbbL3OVD (ORCPT ); Wed, 30 Dec 2015 09:21:03 -0500 Subject: Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl To: Arnd Bergmann , y2038@lists.linaro.org References: <1450346332-31830-1-git-send-email-bamvor.zhangjian@linaro.org> <20151230111648.GA29697@sudip-pc> <5683DB05.7000704@linaro.org> <2440736.t1FM5MM9m8@wuerfel> Cc: gregkh@linuxfoundation.org, broonie@kernel.org, linux-kernel@vger.kernel.org, Sudip Mukherjee , Bamvor Zhang Jian From: Bamvor Jian Zhang Message-ID: <5683E84A.5000301@linaro.org> Date: Wed, 30 Dec 2015 22:20:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <2440736.t1FM5MM9m8@wuerfel> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2031 Lines: 52 Hi, Arnd On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c >> index 31bc7b7..9e98d01 100644 >> --- a/drivers/char/ppdev.c >> +++ b/drivers/char/ppdev.c >> @@ -636,7 +636,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg) >> if ((time32[0] < 0) || (time32[1] < 0)) >> return -EINVAL; >> >> - if (copy_to_user(time32, argp, sizeof(time32))) >> + if (copy_to_user(argp, time32, sizeof(time32))) >> return -EFAULT; >> >> return 0; >> @@ -648,7 +648,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg) >> if ((time64[0] < 0) || (time64[1] < 0)) >> return -EINVAL; >> >> - if (copy_to_user(time64, argp, sizeof(time64))) >> + if (copy_to_user(argp, time64, sizeof(time64))) >> return -EFAULT; >> >> return 0; > > This is something that would be caught by running 'make C=1' with 'sparse' > on your patch. Can you try that to see if you introduce any other warnings? OK. I do not do it before, there is no extra warning after apply the above patch. > I'm guessing it's fine, but it would be nice to confirm. I also send a lot > of patches without running sparse and checkpatch first, but it's generally > a good idea. Got you. I only do the checkpatch in past. I will do sparse and checkpatch in future. Regards Bamvor > > Arnd > _______________________________________________ > Y2038 mailing list > Y2038@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/y2038 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/