Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050AbbL3PTz (ORCPT ); Wed, 30 Dec 2015 10:19:55 -0500 Received: from mail.kernel.org ([198.145.29.136]:43845 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbbL3PTv (ORCPT ); Wed, 30 Dec 2015 10:19:51 -0500 MIME-Version: 1.0 In-Reply-To: References: <1450954863-7540-1-git-send-email-yao.yuan@freescale.com> <20151229183501.GH12450@rob-hp-laptop> From: Rob Herring Date: Wed, 30 Dec 2015 09:19:30 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string To: Yao Yuan Cc: Yuan Yao , "mark.rutland@arm.com" , "pawel.moll@arm.com" , "galak@codeaurora.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1891 Lines: 52 On Tue, Dec 29, 2015 at 9:17 PM, Yao Yuan wrote: > Hi Rob, > > Thanks for your review. > So you mean that I should add the commit message for why I add this new compatible? Please don't top post on the lists. No, the binding doc should explain what are valid combinations of compatible strings and the order when the dts can have multiple strings. For example, is this valid: compatible = "fsl,vf610-dspi", "fsl,ls2080a-dspi"; In other words, I should be able to check a dts file against what the binding doc says. Rob > On Wed, Dec 30, 2015 at 02:35AM, Rob Herring wrote: >> On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote: >> > new compatible string: "fsl,ls2080a-qspi". >> > >> > Signed-off-by: Yuan Yao >> > --- >> > Changed in v2: >> > Update my email to >> > --- >> > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > index fa77f87..2fe51d6 100644 >> > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt >> > @@ -1,7 +1,8 @@ >> > ARM Freescale DSPI controller >> > >> > Required properties: >> > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" >> > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", >> > + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi" >> >> You should explain what combinations of compatible strings are valid. >> >> Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/