Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754738AbbL3QeL (ORCPT ); Wed, 30 Dec 2015 11:34:11 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56095 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbbL3QeH (ORCPT ); Wed, 30 Dec 2015 11:34:07 -0500 Date: Wed, 30 Dec 2015 16:33:07 +0000 From: Mark Brown To: Paul Kocialkowski Cc: Milo Kim , linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Liam Girdwood , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20151230163307.GW16023@sirena.org.uk> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-5-git-send-email-contact@paulk.fr> <20151223115632.GS16023@sirena.org.uk> <568088B4.6090207@ti.com> <1451342963.14631.13.camel@collins> <5681D7A8.2030101@ti.com> <1451387613.18148.9.camel@collins> <568323B7.7080101@ti.com> <1451464521.2531.4.camel@collins> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UTjKcilERHWBCdCp" Content-Disposition: inline In-Reply-To: <1451464521.2531.4.camel@collins> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 35 --UTjKcilERHWBCdCp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > In my opinion, it would be more elegant to adapt the core regulator > framework to first enable the GPIO and then call the regulator enable > ops callback instead of handling the GPIO in the driver. Why would we want to actively manage both things at runtime? It's more work, what do we gain from it? --UTjKcilERHWBCdCp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWhAdCAAoJECTWi3JdVIfQQmYH/jsIV1f+vwmsJYUCVshMxwso +W4sZ+0R9otbA3HQMt1pvQyF8UUaQMk0WatGhbCF88EzOXgO2GCPIcBw1pi7q7mA oUmdbXeHyd4OrTfKi/OOGqlk6kIlrp8i2PHOF3ubOdXvLQHJ3r8JYWufDFpLDaT3 c1FfGW+pC7whF+nixEeoPIJvqvBUCFNA9rTN0jqfS667IqVrztoXACrEkqsHrMtt zV09Cs80t4Ez6W16F2klnh41nntt+Wp9x0FrV2HzIIJzeHz6uwFwabkOi4D8kjhA abIIVVO4nmNiv8kanwP/CblT50iMKre3z366m3jZNxoZtBDQwG7+ZnGjNA8ZB4k= =eFvT -----END PGP SIGNATURE----- --UTjKcilERHWBCdCp-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/