Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755139AbbL3Rti (ORCPT ); Wed, 30 Dec 2015 12:49:38 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35980 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754875AbbL3Rtf (ORCPT ); Wed, 30 Dec 2015 12:49:35 -0500 Subject: Re: [PATCH 4/4] soc: mediatek: Add MT2701/MT7623 scpsys driver To: James Liao , Daniel Kurtz References: <1451457706-14798-1-git-send-email-jamesjj.liao@mediatek.com> <1451457706-14798-5-git-send-email-jamesjj.liao@mediatek.com> <1451470692.22426.11.camel@mtksdaap41> Cc: Sascha Hauer , Kevin Hilman , srv_heupstream , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , Shunli Wang From: Matthias Brugger Message-ID: <5684192B.4020806@gmail.com> Date: Wed, 30 Dec 2015 18:49:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1451470692.22426.11.camel@mtksdaap41> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2559 Lines: 66 On 30/12/15 11:18, James Liao wrote: > Hi Daniel, > > On Wed, 2015-12-30 at 17:01 +0800, Daniel Kurtz wrote: >> On Wed, Dec 30, 2015 at 2:41 PM, James Liao wrote: >>> >>> From: Shunli Wang >>> >>> Add scpsys driver for MT2701 and MT7623. >>> >>> Signed-off-by: Shunli Wang >>> Signed-off-by: James Liao >>> --- >>> drivers/soc/mediatek/Kconfig | 11 +++ >>> drivers/soc/mediatek/Makefile | 1 + >>> drivers/soc/mediatek/mtk-scpsys-mt2701.c | 161 +++++++++++++++++++++++++++++++ >>> 3 files changed, 173 insertions(+) >>> create mode 100644 drivers/soc/mediatek/mtk-scpsys-mt2701.c >>> >>> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig >>> index eca6fb7..92cf838 100644 >>> --- a/drivers/soc/mediatek/Kconfig >>> +++ b/drivers/soc/mediatek/Kconfig >>> @@ -39,3 +39,14 @@ config MTK_SCPSYS_MT8173 >>> driver. >>> The System Control Processor System (SCPSYS) has several power >>> management related tasks in the system. >>> + >>> +config MTK_SCPSYS_MT2701 >>> + bool "SCPSYS Support MediaTek MT2701 and MT7623" >>> + depends on ARCH_MEDIATEK || COMPILE_TEST >>> + select MTK_SCPSYS >>> + default ARCH_MEDIATEK >>> + help >>> + Say yes here to add support for the MT2701/MT7623 SCPSYS power >>> + domain driver. >>> + The System Control Processor System (SCPSYS) has several power >>> + management related tasks in the system. >> >> I don't think we really want different drivers and Kconfig options. >> >> Can we just use different compatibles to select the appropriate scp_domain_data? > > Yes, we can. All scpsys drivers are built-in by default, and they will > be activate by specific compatible string. > > But some projects don't want to build unused drivers into kernel to save > code size. Use different Kconfig options for each SoC so that these > projects can disable unused drivers. > Scpsys is a bool right now, you can disable it if you don't need it for your project. I don't think the impact of adding scp_domain_data justifies adding SoC specific scpsys drivers and bloat the drivers/soc/mediatek folder. Best regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/