Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754040AbbL3Tzk (ORCPT ); Wed, 30 Dec 2015 14:55:40 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:34937 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752118AbbL3Tzg convert rfc822-to-8bit (ORCPT ); Wed, 30 Dec 2015 14:55:36 -0500 MIME-Version: 1.0 In-Reply-To: <56842DDF.6040109@codeaurora.org> References: <1449677909-12432-1-git-send-email-okaya@codeaurora.org> <1449677909-12432-2-git-send-email-okaya@codeaurora.org> <56686037.70109@codeaurora.org> <56686171.5060102@codeaurora.org> <5683DAD3.4080006@codeaurora.org> <56842DDF.6040109@codeaurora.org> Date: Wed, 30 Dec 2015 21:55:35 +0200 Message-ID: Subject: Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction From: Andy Shevchenko To: Sinan Kaya Cc: Christopher Covington , "linux-acpi@vger.kernel.org" , Timur Tabi , jcm@redhat.com, helgaas@kernel.org, "Rafael J. Wysocki" , Len Brown , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 26 On Wed, Dec 30, 2015 at 9:17 PM, Sinan Kaya wrote: > On 12/30/2015 8:28 AM, Andy Shevchenko wrote: >> Yep, I meant not to use an additional variable. >> >>> > BTW, I suggest you spend some time around checkpatch for contributions. I could >>> > have caught most of the issues you are generally concerned before submitting a patch. >> Is it a question? > > It is a request not a question. I hate wasting your time and my time with things that I could > have fixed before submitting a patch. > > I ran the checkpatch and it said I'm good to go. But, obviously I'm not. Hmm… checkpatch.pl is just a small helper to fix style issues. Here is just a common sense rule, or kind of Occam's razor: no need to have more variables then needed if it doesn't improve something really significantly. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/