Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754417AbbL3Wcz (ORCPT ); Wed, 30 Dec 2015 17:32:55 -0500 Received: from ozlabs.org ([103.22.144.67]:35918 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbbL3Wcv (ORCPT ); Wed, 30 Dec 2015 17:32:51 -0500 Date: Thu, 31 Dec 2015 09:32:48 +1100 From: Stephen Rothwell To: Andrew Morton Cc: Michal Hocko , Jeremiah Mahler , linux-kernel@vger.kernel.org, Kees Cook , Andy Lutomirski , Will Drewry , Ingo Molnar , Tejun Heo Subject: Re: BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894 Message-ID: <20151231093248.4ce475e2@canb.auug.org.au> In-Reply-To: <20151229103037.68d1643d.akpm@linux-foundation.org> References: <20151224171253.GA3148@hudson.localdomain> <20151229162346.GB10321@dhcp22.suse.cz> <20151229103037.68d1643d.akpm@linux-foundation.org> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2081 Lines: 56 Hi Andrew, On Tue, 29 Dec 2015 10:30:37 -0800 Andrew Morton wrote: > > On Tue, 29 Dec 2015 17:23:47 +0100 Michal Hocko wrote: > > > [CCing Andrew] > > > > On Thu 24-12-15 09:12:53, Jeremiah Mahler wrote: > > > all, > > > > > > I have started seeing a "Bad rss-counter" message in the logs with > > > the latest linux-next 20151222+. > > > > > > [ 458.282192] BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894 > > > > This is MM_SHMEMPAGES so an "unamapped" shmem memory. One possible > > reason might be an unitialized zap_details used from unmap_mapping_range > > during truncate introduced by "mm, oom: introduce oom reaper" from the > > mmotm tree. There is a fix for this which is still pending > > http://lkml.kernel.org/r/1450487091-7822-1-git-send-email-sasha.levin%40oracle.com > > That won't be getting fixed until linux-next returns from holidays. > > This: > > --- a/mm/memory.c~mm-oom-introduce-oom-reaper-fix-5-fix > +++ a/mm/memory.c > @@ -2415,7 +2415,7 @@ static inline void unmap_mapping_range_t > void unmap_mapping_range(struct address_space *mapping, > loff_t const holebegin, loff_t const holelen, int even_cows) > { > - struct zap_details details; > + struct zap_details details = { }; > pgoff_t hba = holebegin >> PAGE_SHIFT; > pgoff_t hlen = (holelen + PAGE_SIZE - 1) >> PAGE_SHIFT; > OK, I have added the following from mmots to linux-next today (though I may not get a release done): mm-oom-introduce-oom-reaper-fix-4-fix.patch mm-oom-introduce-oom-reaper-fix-4.patch mm-oom-introduce-oom-reaper-fix-5-fix.patch mm-oom-introduce-oom-reaper-fix-5.patch mm-oom-introduce-oom-reaper-fix-6.patch mmoom-exclude-tif_memdie-processes-from-candidates.patch -- Cheers, Stephen Rothwell sfr@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/