Date: Wed, 30 Dec 2015 23:50:40 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiang Liu <jiang.liu@linux.intel.com>
cc: Joe Lawrence <joe.lawrence@stratus.com>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Jeremiah Mahler <jmmahler@gmail.com>, Borislav Petkov <bp@alien8.de>,
        andy.shevchenko@gmail.com, Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [Bugfix v2 4/5] x86/irq: Fix a race condition between vector
 assigning and cleanup
In-Reply-To: <1450880014-11741-4-git-send-email-jiang.liu@linux.intel.com>
Message-ID: <alpine.DEB.2.11.1512302348090.28591@nanos>
References: <alpine.DEB.2.11.1512192130450.28591@nanos> <1450880014-11741-1-git-send-email-jiang.liu@linux.intel.com> <1450880014-11741-4-git-send-email-jiang.liu@linux.intel.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 27

On Wed, 23 Dec 2015, Jiang Liu wrote:
>  		/*
> -		 * Check if the irq migration is in progress. If so, we
> -		 * haven't received the cleanup request yet for this irq.
> +		 * Nothing to cleanup if this cpu is not set
> +		 * in the old_domain mask.
>  		 */
> -		if (data->move_in_progress)
> -			goto unlock;
> -
> -		if (vector == data->cfg.vector &&
> -		    cpumask_test_cpu(me, data->domain))

Actually we cannot remove this check either. If the vector changed from 100 to
80, then we cleanup vector 80 which is the active vector and the old one
remains stale. Not pretty, right?

I'll send out a fine granular series tomorrow when my brain is more awake.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/