Message-ID: <568486A9.10602@cmss.chinamobile.com>
Date: Thu, 31 Dec 2015 09:36:41 +0800
From: Xiubo Li <lixiubo@cmss.chinamobile.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: flat: introduce register striding to savesomememories
References: <1450077274-25942-1-git-send-email-lixiubo@cmss.chinamobile.com> <20151214175756.GW5727@sirena.org.uk> <566FD138.4010601@cmss.chinamobile.com> <20151218082321.GW5727@sirena.org.uk> <2015121816593812599420@cmss.chinamobile.com> <20151230175830.GA16023@sirena.org.uk>
In-Reply-To: <20151230175830.GA16023@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1059
Lines: 38


On 31/12/2015 01:58, Mark Brown wrote:
> On Fri, Dec 18, 2015 at 04:59:38PM +0800, lixiubo@cmss.chinamobile.com wrote:
>
>>> I think we'll need to continue supporting non power of two strides so
>>> an unconditional conversion to shifts might be an issue - some weird DSP
>>> probably does that.
>
>> Yes, agreed.
>
>> IMO this won't happen to MMIO, and for the device using MMIO the
>> register strides should equal to power of two.
>
>> Are there some cases I have met?
>
> DSPs exposed via I2C and SPI are the main things I'm worried about.
> It's fairly common for DSPs to have unusual word sizes including things
> like three bytes.
>

Yes, if so, for this case the non power of two strides should be still 
supported.

Thanks for your promotion, and I will think over of this carefully.

BRs

Xiubo Li


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/