Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751640AbbLaFVc (ORCPT ); Thu, 31 Dec 2015 00:21:32 -0500 Received: from mail-db5eur01on0067.outbound.protection.outlook.com ([104.47.2.67]:26992 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750974AbbLaFVa convert rfc822-to-8bit (ORCPT ); Thu, 31 Dec 2015 00:21:30 -0500 From: Noam Camus To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "Chris Metcalf" , "daniel.lezcano@linaro.org" , "marc.zyngier@arm.com" Subject: Re: [PATCH v5 10/20] ARC: IRQ: do not use hwirq directly at arch_do_IRQ() Thread-Topic: [PATCH v5 10/20] ARC: IRQ: do not use hwirq directly at arch_do_IRQ() Thread-Index: AQHRQKqE4GIgQjz0a0Ss7RRnNjyvdJ7jU1QAgAE/uI8= Date: Thu, 31 Dec 2015 05:21:26 +0000 Message-ID: References: <1451222619-3610-1-git-send-email-noamc@ezchip.com> <1451222619-3610-11-git-send-email-noamc@ezchip.com>,<5683AD9E.10501@synopsys.com> In-Reply-To: <5683AD9E.10501@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=noamc@ezchip.com; x-originating-ip: [157.56.250.69] x-microsoft-exchange-diagnostics: 1;DB3PR02MB124;5:QS9+f4BoARYMLNiv3IkDOiaXx83z68Z5Y+4JuCyW5nziiMnvpUV36k5BAKCUTb0+qmEkLwVLkfTZp8m7CCFb6OZkVABY5iN5HqmazojG3L4/rWaAlgR4IGk1l8oor8KdZ7XQFVeiG6EAtDI7cPQnYQ==;24:beaPOgmbscRrh1jTm8izVIpbVxUq5rpZHRK9szVv/jfAlaCLCvrYdz+DvWG9q86QOpcYl7Otoy1YzdFA+Fw+nL02noJNgr0w57dvQK6uLu8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB124; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046);SRVR:DB3PR02MB124;BCL:0;PCL:0;RULEID:;SRVR:DB3PR02MB124; x-forefront-prvs: 08076ABC99 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(199003)(377454003)(189002)(2900100001)(4326007)(11100500001)(189998001)(77096005)(81156007)(5001960100002)(5003600100002)(2501003)(5002640100001)(92566002)(5008740100001)(87936001)(106116001)(74316001)(97736004)(2950100001)(86362001)(101416001)(33656002)(10400500002)(106356001)(40100003)(122556002)(6116002)(5004730100002)(19580395003)(76576001)(105586002)(1096002)(102836003)(1220700001)(66066001)(19580405001)(50986999)(54356999)(586003)(76176999)(3846002)(5001770100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR02MB124;H:HE1PR02MB1387.eurprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2015 05:21:26.9438 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR02MB124 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 33 >From: Vineet Gupta >Sent: Wednesday, December 30, 2015 12:10 PM >> --- a/arch/arc/Kconfig >> +++ b/arch/arc/Kconfig >> @@ -32,6 +32,7 @@ config ARC >> select HAVE_OPROFILE >> select HAVE_PERF_EVENTS >> select IRQ_DOMAIN >> + select HANDLE_DOMAIN_IRQ if ARC_PLAT_EZNPS >On same lines as prev comment - just do this unconditionally for ARC port - assuming this works with legacy domain as well. Yes it should work for legacy domain. On the other hand I can select it at the driver Kconfig itself and remove this line altogether. >> >> +#ifdef CONFIG_HANDLE_DOMAIN_IRQ >> +extern void set_handle_irq(void (*handle_irq)(unsigned int hwirq, >> + struct pt_regs *)); >> +#endif >Not needed ! I need to have it since we do not know at arch/arc/kernel/irq.c what is the domain allocated by the timer driver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/