Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbbLaHXz (ORCPT ); Thu, 31 Dec 2015 02:23:55 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34973 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbbLaHXw (ORCPT ); Thu, 31 Dec 2015 02:23:52 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 31 Dec 2015 02:23:50 -0500 Message-ID: Subject: Re: [PULL] Re: bcache stability patches From: Denis Bychkov To: Eric Wheeler Cc: Jens Axboe , Kent Overstreet , Al Viro , g2p.code@gmail.com, Jiri Kosina , Joshua Schmid , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, stefan.bader@canonical.com, Takashi Iwai , Vojtech Pavlik , Zheng Liu , Zheng Liu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4206 Lines: 107 On Tue, Dec 29, 2015 at 10:00 PM, Eric Wheeler wrote: > Hi Jens and Kent, > > This affects many users, so please take a look when you have a moment: > > There is a growing bcache user community with a well-tested patchset that > is necessary for production bcache use. The diffstat is small and we all > want someone to pull it in and get it into mainline. This would serve > many people if this can get pulled in upstream. > > More below: > > On Tue, 22 Dec 2015, Denis Bychkov wrote: >> There is a set of bcache stability patches elevating bcache stability to >> production level. As far as I know, there is no single reported and peer >> confirmed bug that is not solved by this set. Unfortunately, for some >> reason, Kent does not have enough time and/or energy to review them and >> send them upstream. Let's come up with a solution that would allow to >> review all these patches (some of them written by Ken himself, some of >> them produced by the community), review them and hand them to the >> maintainer who is willing to apply them upstream. Without that, bcache >> is just another half-assed unstable and buggy cache layer. These patches >> will allow people to start use bcache in production systems. Please find >> the patch set attached. (The patches apply cleanly to 4.3 and 4.4 kernel >> series). > > Hi Dennis, > > I'm maintaining a branch here that is ready to merge. We have been > testing this for about a year in production and works great. All Cc's and > authors are correct and it (should) have every stability patch below, > possibly others too. Please tell me if there are any patches missing: Just went through all the patches I have, looks like you did not miss any. The only small correction - the author of commit 53803810fce7826feff7d5632a7ab3cc991e6243 is me, not Gabriel de Perthuis. Gabriel wrote the original patch which I mention in the comment, but it was broken (did not release the mutex), so I created a new one, that actually fixed the problem with device_busy error. > > git pull https://github.com/ewheelerinc/linux.git bcache-patches-for-3.17 > (Yes, github for hosting only, I don't edit with their web interfaces.) > > Note that this branch still merges cleanly through v4.4-rc7 and as far > back as 3.17-rc1 (maybe earlier). Each patch provides Cc: stable@vger.kernel.org. > > It is ready to merge! We just need Jens or Kent or someone to pull it in. > Here is the diffstat and shortlog against v4.4-rc7: > > drivers/md/bcache/btree.c | 5 ++++- > drivers/md/bcache/super.c | 16 ++++++++++++---- > drivers/md/bcache/writeback.c | 37 ++++++++++++++++++++++++++++++------- > drivers/md/bcache/writeback.h | 3 ++- > 4 files changed, 48 insertions(+), 13 deletions(-) > > Al Viro (1): > bcache: fix a leak in bch_cached_dev_run() > > Gabriel de Perthuis (1): > bcache: allows use of register in udev to avoid "device_busy" error. > > Kent Overstreet (2): > bcache: Add a cond_resched() call to gc > bcache: Change refill_dirty() to always scan entire disk if > necessary > > Stefan Bader (1): > bcache: prevent crash on changing writeback_running > > Zheng Liu (3): > bcache: fix a livelock when we cause a huge number of cache misses > bcache: clear BCACHE_DEV_UNLINK_DONE flag when attaching a backing device > bcache: unregister reboot notifier if bcache fails to unregister device > > See also these threads: > https://lkml.org/lkml/2015/12/5/38 > https://www.mail-archive.com/linux-bcache@vger.kernel.org/msg03159.html > > Quickly view commits here, too: > https://github.com/ewheelerinc/linux/commits/bcache-patches-for-3.17 > > > Cheers, > > -Eric > > > -- > Eric Wheeler, President eWheeler, Inc. dba Global Linux Security > 888-LINUX26 (888-546-8926) Fax: 503-716-3878 PO Box 25107 > www.GlobalLinuxSecurity.pro Linux since 1996! Portland, OR 97298 > -- Denis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/