Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755383AbbLaIci (ORCPT ); Thu, 31 Dec 2015 03:32:38 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33481 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbbLaIcf (ORCPT ); Thu, 31 Dec 2015 03:32:35 -0500 Subject: Re: [PATCH 1/4] spi: mediatek: merge all identical compat to mtk_common_compat To: Leilk Liu , Mark Brown References: <1451530743-8995-1-git-send-email-leilk.liu@mediatek.com> <1451530743-8995-2-git-send-email-leilk.liu@mediatek.com> Cc: Mark Rutland , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org From: Matthias Brugger Message-ID: <5684E807.30300@gmail.com> Date: Thu, 31 Dec 2015 09:32:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1451530743-8995-2-git-send-email-leilk.liu@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1870 Lines: 53 On 31/12/15 03:59, Leilk Liu wrote: > This patch merge all identical compat into on mtk_common_compat > and used for all compatible soc. > > Signed-off-by: Leilk Liu > --- Reviewed-by: Matthias Brugger > drivers/spi/spi-mt65xx.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c > index 563954a..3573c09 100644 > --- a/drivers/spi/spi-mt65xx.c > +++ b/drivers/spi/spi-mt65xx.c > @@ -95,8 +95,7 @@ struct mtk_spi { > const struct mtk_spi_compatible *dev_comp; > }; > > -static const struct mtk_spi_compatible mt6589_compat; > -static const struct mtk_spi_compatible mt8135_compat; > +static const struct mtk_spi_compatible mtk_common_compat; > static const struct mtk_spi_compatible mt8173_compat = { > .need_pad_sel = true, > .must_tx = true, > @@ -112,9 +111,15 @@ static const struct mtk_chip_config mtk_default_chip_info = { > }; > > static const struct of_device_id mtk_spi_of_match[] = { > - { .compatible = "mediatek,mt6589-spi", .data = (void *)&mt6589_compat }, > - { .compatible = "mediatek,mt8135-spi", .data = (void *)&mt8135_compat }, > - { .compatible = "mediatek,mt8173-spi", .data = (void *)&mt8173_compat }, > + { .compatible = "mediatek,mt6589-spi", > + .data = (void *)&mtk_common_compat, > + }, > + { .compatible = "mediatek,mt8135-spi", > + .data = (void *)&mtk_common_compat, > + }, > + { .compatible = "mediatek,mt8173-spi", > + .data = (void *)&mt8173_compat, > + }, > {} > }; > MODULE_DEVICE_TABLE(of, mtk_spi_of_match); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/