Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbbLaNM6 (ORCPT ); Thu, 31 Dec 2015 08:12:58 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42382 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbbLaNM4 (ORCPT ); Thu, 31 Dec 2015 08:12:56 -0500 From: Kalle Valo To: Andrzej Hajda Cc: QCA ath9k Development , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate References: <1450087564-28441-1-git-send-email-a.hajda@samsung.com> <1450087564-28441-4-git-send-email-a.hajda@samsung.com> Date: Thu, 31 Dec 2015 15:12:46 +0200 In-Reply-To: <1450087564-28441-4-git-send-email-a.hajda@samsung.com> (Andrzej Hajda's message of "Mon, 14 Dec 2015 11:06:01 +0100") Message-ID: <87ege2oj75.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 21 Andrzej Hajda writes: > The function can return negative values in case of error. > Its result should be then tested for such case. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda Applied to ath.git, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/