Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbbLaWOi (ORCPT ); Thu, 31 Dec 2015 17:14:38 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57933 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbbLaWOf (ORCPT ); Thu, 31 Dec 2015 17:14:35 -0500 Date: Thu, 31 Dec 2015 22:14:07 +0000 From: Mark Brown To: Paul Kocialkowski Cc: Milo Kim , linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Liam Girdwood , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20151231221407.GF16023@sirena.org.uk> References: <568088B4.6090207@ti.com> <1451342963.14631.13.camel@collins> <5681D7A8.2030101@ti.com> <1451387613.18148.9.camel@collins> <568323B7.7080101@ti.com> <1451464521.2531.4.camel@collins> <20151230163307.GW16023@sirena.org.uk> <1451500639.14341.6.camel@collins> <20151231214007.GC16023@sirena.org.uk> <1451599146.9673.2.camel@collins> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iBipwI8N6cjWJAiJ" Content-Disposition: inline In-Reply-To: <1451599146.9673.2.camel@collins> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 47 --iBipwI8N6cjWJAiJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote: > I understand, thanks for pointing this out. Well, for my use case, there > is no use in disabling the chip at any point as it powers the external > mmc. Presumably someone might decide not to use the MMC in some case (perhaps only mounting it when explicitly needed in order to save power for example, or the MMC subsystem might figure out a way to power down an idle MMC block device). > Would you agree to have the enable pin handled directly (and by that, I > mean enabled once, when requested, as I first suggested in the patchset) > in the driver then? That's probably fine, or do it via runtime PM (the framework is fairly simple to use, I'll probably go add support in the core for it in the next day or two as this seems like a sensible use case). I can't remember if this device is a MFD or not and I'm just on my way out the door. --iBipwI8N6cjWJAiJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWhaivAAoJECTWi3JdVIfQBTwH/0c97iPmjv0ncNLyJswoLHqH RR8JvifjbS7jtarqTON7EfCHu2P4ChZKCEsTUpph5h5T95lQUj6Z8BGscgCUlkXG TB2sxJzf+8kQecbleQmbXYG6FjyK4s0oK8Dm0f/m3m5LdRXoosMSy11gJ6eLrGmI ydei7K8T1YZU7tEdDSV4qB1iRaKLl3YDD7Pd/UUk6GVq7SIJXbzO+U43R8t9GnI4 KYw6R92LgbkKBN6MFKCHdzNeooxhIiwF2lIiiccJTAIvIGnNoFzbxkFapK+nvWhn cisUfBnWxAkEAmlImyX2xwygNON56NOvmdHYqKnbs1jV2ybG60qJLfxhv80BzXw= =Yj1A -----END PGP SIGNATURE----- --iBipwI8N6cjWJAiJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/