Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbbLaWTx (ORCPT ); Thu, 31 Dec 2015 17:19:53 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57955 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbbLaWTu (ORCPT ); Thu, 31 Dec 2015 17:19:50 -0500 Date: Thu, 31 Dec 2015 22:19:35 +0000 From: Mark Brown To: Danny Milosavljevic Cc: Maxime Ripard , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-sunxi@googlegroups.com Message-ID: <20151231221935.GG16023@sirena.org.uk> References: <20151221123148.1ab6480b@dayas> <20151221123416.51aa938e@dayas> <20151227182157.GI30359@lukather> <20151228040649.475a742f@dayas> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="evOcBaiMpN7OEvsd" Content-Disposition: inline In-Reply-To: <20151228040649.475a742f@dayas> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2507 Lines: 66 --evOcBaiMpN7OEvsd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 28, 2015 at 04:06:49AM +0100, Danny Milosavljevic wrote: > Maxime Ripard wrote: > > > +static SOC_ENUM_SINGLE_DECL(sun4i_codec_enum_capture_source, > > > + SUN4I_CODEC_ADC_ACTL, > > > + SUN4I_CODEC_ADC_ACTL_ADCIS, > > > + sun4i_codec_capture_source); > > Isn't it possible to expose this as two (shared) muxes with different > > names to make it clear what will go to the left ADC and what will go > > to the right? > I don't know how to do that. I'll try to find out. > Can two muxes use the same bit in the hardware without problems? IIRC we fixed things so that if you've got two controls that share the same register we do the right thing. There are other devices with this issue but it was years ago that I last looked at them, we do have handling. > > Those are not volume it's gain,=20 > We tried to call the things ..." Gain" before and it was difficult to do,= =20 > with some breakage along the way, see below. > Also, Mark said they should be named ..." Volume" (see=20 > = ). >=20 > >and it should probably be two different shared controls for mic1 and mic= 2. Yes, this is part of the ABI and honestly from an end user point of view there is no meaningful difference between the two words (there would be more if it were gain and attenuation since one is amplification and the other isn't so there are different considerations when applying them to signals but that's not the case here). --evOcBaiMpN7OEvsd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWhan2AAoJECTWi3JdVIfQ3lEH/Rf7wie9xgOTF/KcsAemu0im WalNu1Odk4F/GU5Z1QhFu1EB5NBN/MVjsjUQ1XuRn/3T547+kfNfsB/1Cm4pf89g YkR6sSxT9Ode/+0omkH0sQqz/d/fNETU0zTzPenRarg7tOLbrw9KigXjX8M8n246 qwvk5qt90I/uy5FhXTPcaX1rOeTo7//vjQusMZ89jOUoR2cyGEpoPlG7l+VV1lXs 5tVlvEGKj1B5Y1C6KmmGRhAzPWsA87h9pwBBlsFGjw2VarpHTNKNw3+RtAA9+Cmd iklmfXKjjrBi6XlHizKzFs0knx2C2J+H8ZpPd0xLZsw4YILAz649zJRniVM4/fY= =8emD -----END PGP SIGNATURE----- --evOcBaiMpN7OEvsd-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/