Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbcAAAST (ORCPT ); Thu, 31 Dec 2015 19:18:19 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:58417 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750977AbcAAASI convert rfc822-to-8bit (ORCPT ); Thu, 31 Dec 2015 19:18:08 -0500 From: "Rafael J. Wysocki" To: Andy Shevchenko Cc: Sinan Kaya , Christopher Covington , "linux-acpi@vger.kernel.org" , Timur Tabi , jcm@redhat.com, helgaas@kernel.org, Len Brown , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction Date: Fri, 01 Jan 2016 01:48:40 +0100 Message-ID: <6338540.F7x0ET9vtV@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1449677909-12432-1-git-send-email-okaya@codeaurora.org> <56842DDF.6040109@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 30 On Wednesday, December 30, 2015 09:55:35 PM Andy Shevchenko wrote: > On Wed, Dec 30, 2015 at 9:17 PM, Sinan Kaya wrote: > > On 12/30/2015 8:28 AM, Andy Shevchenko wrote: > >> Yep, I meant not to use an additional variable. > >> > >>> > BTW, I suggest you spend some time around checkpatch for contributions. I could > >>> > have caught most of the issues you are generally concerned before submitting a patch. > >> Is it a question? > > > > It is a request not a question. I hate wasting your time and my time with things that I could > > have fixed before submitting a patch. > > > > I ran the checkpatch and it said I'm good to go. But, obviously I'm not. > > Hmm… checkpatch.pl is just a small helper to fix style issues. Here is > just a common sense rule, or kind of Occam's razor: no need to have > more variables then needed if it doesn't improve something really > significantly. That said, compilers optimize things anyway, so using an extra local variable shouldn't matter for the resulting machine code. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/