Date: Fri, 1 Jan 2016 10:10:35 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Richard Guy Briggs <rgb@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Serge E. Hallyn" <serge@hallyn.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC] is_global_init() called on global init sub-thread
Message-ID: <20160101011035.GA538@swordfish>
References: <20151230062542.GA605@swordfish>
 <20160101010823.GB26243@mail.hallyn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160101010823.GB26243@mail.hallyn.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 33

On (12/31/15 19:08), Serge E. Hallyn wrote:
> > re-upping https://www.redhat.com/archives/linux-audit/2013-December/msg00086.html
> > 
> > Oleg Nesterov wrote:
> > 
> > :Because is_global_init() is only true for the main thread of /sbin/init.
> > :
> > :Just look at oom_unkillable_task(). It tries to not kill init. But, say,
> > :select_bad_process() can happily find a sub-thread of is_global_init()
> > :and still kill it.
> > 
> > this is still the case, isn't it? at least in some -stable kernels.
> > is there (or was there) any reason this change has never been committed?
> > (I'm particularly interested in is_global_init()).
> 
> ...  seems like it makes sense.  Can you remind us which init you're having
> to deal with?
> 

systemd

	-ss

> >  static inline int is_global_init(struct task_struct *tsk)
> >  {
> > -	return tsk->pid == 1;
> > +	return task_tgid_nr(tsk) == 1;
> >  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/