Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbcAABSg (ORCPT ); Thu, 31 Dec 2015 20:18:36 -0500 Received: from h2.hallyn.com ([78.46.35.8]:48414 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbcAABSd (ORCPT ); Thu, 31 Dec 2015 20:18:33 -0500 Date: Thu, 31 Dec 2015 19:18:31 -0600 From: "Serge E. Hallyn" To: Sergey Senozhatsky Cc: "Serge E. Hallyn" , Sergey Senozhatsky , Oleg Nesterov , Peter Zijlstra , Andrew Morton , Richard Guy Briggs , "Eric W. Biederman" , "Serge E. Hallyn" , linux-kernel@vger.kernel.org Subject: Re: [RFC] is_global_init() called on global init sub-thread Message-ID: <20160101011831.GA26628@mail.hallyn.com> References: <20151230062542.GA605@swordfish> <20160101010823.GB26243@mail.hallyn.com> <20160101011035.GA538@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160101011035.GA538@swordfish> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1421 Lines: 36 On Fri, Jan 01, 2016 at 10:10:35AM +0900, Sergey Senozhatsky wrote: > On (12/31/15 19:08), Serge E. Hallyn wrote: > > > re-upping https://www.redhat.com/archives/linux-audit/2013-December/msg00086.html > > > > > > Oleg Nesterov wrote: > > > > > > :Because is_global_init() is only true for the main thread of /sbin/init. > > > : > > > :Just look at oom_unkillable_task(). It tries to not kill init. But, say, > > > :select_bad_process() can happily find a sub-thread of is_global_init() > > > :and still kill it. > > > > > > this is still the case, isn't it? at least in some -stable kernels. > > > is there (or was there) any reason this change has never been committed? > > > (I'm particularly interested in is_global_init()). > > > > ... seems like it makes sense. Can you remind us which init you're having > > to deal with? > > > > systemd > > -ss Well it makes sense to me. The question is whether we are protecting the thing running as init, or the 'physical' thread with pid 1. I think it's the former, so let's push on this. Please resend the patch with a proper signed-off-by, and feel free to add Acked-by: Serge Hallyn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/