Content-Type: text/plain;
	charset=gb2312
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v4 06/16] perf tools: Support perf event alias name
From: pi3orama <pi3orama@163.com>
In-Reply-To: <20151211120301.GO17996@kernel.org>
Date: Fri, 11 Dec 2015 20:12:56 +0800
Cc: Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        namhyung@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org,
        lizefan@huawei.com, He Kuang <hekuang@huawei.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <5B68F5FB-C8C7-4283-9B35-BE0A083F2D74@163.com>
References: <1449541544-67621-1-git-send-email-wangnan0@huawei.com> <1449541544-67621-7-git-send-email-wangnan0@huawei.com> <20151211120301.GO17996@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1514
Lines: 43


?????ҵ? iPhone

> ?? 2015??12??11?գ?????8:03??Arnaldo Carvalho de Melo <acme@kernel.org> д????
> 
> Em Tue, Dec 08, 2015 at 02:25:34AM +0000, Wang Nan escreveu:
>> From: He Kuang <hekuang@huawei.com>
>> 
>> This patch adds new bison rules for specifying an alias name to a perf
>> event, which allows cmdline refer to previous defined perf event through
>> its name. With this patch user can give alias name to a perf event using
>> following cmdline:
> 
> Please add Jiri Olsa to any changes that touches the parser changes.
> 
> Can you reword the above phrase? Does it mean something like:
> 
> ----
> This patches adds new bison rules for specifying an alias to a perf
> event, which allows referring to this previously defined perf event
> through this alias."
> ----
> 
> But then, why would I want this aliasing? The provided examples shows a
> way to obfuscate 'cycles', a perfectly good name, why would one want to
> call it "mypmu"?
> 

Sorry. I should put this patch after 7/16 so you won't get confused. Without event
aliasing it is hard to select an event and insert it into a BPF map.

Patch 7/16 would use alias like:

 # perf record -e evt=cycles/no-inherit/ -e BPF.c/maps.pmu.event=evt/ ...
So it put cycles/no-inherit/ into that map.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/