Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbbLVIEe (ORCPT ); Tue, 22 Dec 2015 03:04:34 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33008 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753872AbbLVIE0 (ORCPT ); Tue, 22 Dec 2015 03:04:26 -0500 Subject: Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() To: Andrey Ryabinin , "David S. Miller" References: <1450691685-29413-1-git-send-email-aryabinin@virtuozzo.com> Cc: Cong Wang , hideaki.yoshifuji@miraclelinux.com, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev , "linux-kernel@vger.kernel.org" From: YOSHIFUJI Hideaki Organization: MIRACLE LINUX CORPORATION Message-ID: <56790406.5080206@miraclelinux.com> Date: Tue, 22 Dec 2015 17:04:22 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 25 Cong Wang wrote: > On Mon, Dec 21, 2015 at 1:54 AM, Andrey Ryabinin > wrote: >> ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, >> ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, >> ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. >> >> Fix this by inverting ip6addrlbl_hold() check. >> >> Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.") >> Signed-off-by: Andrey Ryabinin > > Good catch! > > Reviewed-by: Cong Wang Acked-by: YOSHIFUJI Hideaki -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/