Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751233AbcCAFba (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 00:31:30 -0500
Received: from conssluserg003.nifty.com ([202.248.44.41]:32474 "EHLO
	conssluserg003-v.nifty.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1750821AbcCAFb3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 00:31:29 -0500
X-Nifty-SrcIP: [209.85.161.177]
MIME-Version: 1.0
In-Reply-To: <1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com>
References: <1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com>
Date: Tue, 1 Mar 2016 14:31:10 +0900
X-Gmail-Original-Message-ID: <CAK7LNAT0YCHbh7CfWKG1bZiJCXNXk7Jv6sdQz_9Sa6OG5zScrg@mail.gmail.com>
Message-ID: <CAK7LNAT0YCHbh7CfWKG1bZiJCXNXk7Jv6sdQz_9Sa6OG5zScrg@mail.gmail.com>
Subject: Re: [PATCH] tools build: use .s extension for preprocessed assembler code
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
        Aaro Koskinen <aaro.koskinen@nokia.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Lukas Wunner <lukas@wunner.de>, Jiri Olsa <jolsa@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1156
Lines: 48

Hi Arnaldo,

Do you have any comment on this patch?

(I hope I am addressing myself to a right person.
"git log --pretty=fuller tools/build/Makefile.build" showed that
several patches in this area had been applied by you.)


Thanks,


2016-02-01 2:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> The "man gcc" says .i extension represents the file is C source code
> that should not be preprocessed.  Here, .s should be used.
>
> For clarification,
>   .c  ---(preprocess)--->  .i
>   .S  ---(preprocess)--->  .s
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  tools/build/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 4a96473..ee566e8 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
>         $(call rule_mkdir)
>         $(call if_changed_dep,cc_i_c)
>
> -$(OUTPUT)%.i: %.S FORCE
> +$(OUTPUT)%.s: %.S FORCE
>         $(call rule_mkdir)
>         $(call if_changed_dep,cc_i_c)
>
> --
> 1.9.1
>



-- 
Best Regards
Masahiro Yamada