Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbcCAH3T (ORCPT ); Tue, 1 Mar 2016 02:29:19 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:47555 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcCAH3Q (ORCPT ); Tue, 1 Mar 2016 02:29:16 -0500 Date: Tue, 1 Mar 2016 12:58:29 +0530 From: Varun Prakash To: "Nicholas A. Bellinger" CC: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] target/cxgbit: add INET dependency Message-ID: <20160301072828.GA1704@chelsio.com> References: <1456744504-3011977-1-git-send-email-arnd@arndb.de> <1456810108.19657.187.camel@haakon3.risingtidesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1456810108.19657.187.camel@haakon3.risingtidesystems.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.193.190.56] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 40 On Tue, Mar 01, 2016 at 10:58:28AM +0530, Nicholas A. Bellinger wrote: > Hi Arnd, > > On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote: > > The newly added cxgbit driver directly calls functions of the > > IPv4 network stack, which fails if that is disabled: > > > > ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined! > > ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined! > > > > This adds a Kconfig dependency to ensure we can't enable this > > driver without the complete network stack it needs. > > > > Signed-off-by: Arnd Bergmann > > Fixes: b7ca3321e114 ("cxgbit: add Kconfig and Makefile") > > --- > > drivers/target/iscsi/cxgbit/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/target/iscsi/cxgbit/Kconfig b/drivers/target/iscsi/cxgbit/Kconfig > > index cf335b4dbb4e..ce6f5cca315d 100644 > > --- a/drivers/target/iscsi/cxgbit/Kconfig > > +++ b/drivers/target/iscsi/cxgbit/Kconfig > > @@ -1,6 +1,7 @@ > > config ISCSI_TARGET_CXGB4 > > tristate "Chelsio iSCSI target offload driver" > > depends on ISCSI_TARGET && CHELSIO_T4 > > + depends on INET > > select CHELSIO_T4_UWIRE > > ---help--- > > To compile this driver as module, choose M here: the module > > Odd, ISCSI_TARGET already depends on NET, but I guess that's not enough > for cxgbit.. ;) > > Varun, please pick this up and fold it into the original commit, with > proper credit to Arnd for finding this in the commit log. I will update the original commit in v2 series, thanks Arnd for finding this.