Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbcCAJBz (ORCPT ); Tue, 1 Mar 2016 04:01:55 -0500 Received: from mail-qg0-f68.google.com ([209.85.192.68]:33350 "EHLO mail-qg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbcCAJBx (ORCPT ); Tue, 1 Mar 2016 04:01:53 -0500 MIME-Version: 1.0 In-Reply-To: <1456778924-20730-6-git-send-email-paul.gortmaker@windriver.com> References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-6-git-send-email-paul.gortmaker@windriver.com> Date: Tue, 1 Mar 2016 10:01:52 +0100 Message-ID: Subject: Re: [PATCH 5/8] drivers/pinctrl: make stm32/pinctrl-stm32f429.c explicitly non-modular From: Maxime Coquelin To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Linus Walleij , Patrice Chotard , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 34 2016-02-29 21:48 GMT+01:00 Paul Gortmaker : > The Kconfig currently controlling compilation of this code is: > > drivers/pinctrl/stm32/Kconfig:config PINCTRL_STM32F429 > drivers/pinctrl/stm32/Kconfig: bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Maxime Coquelin > Cc: Patrice Chotard > Cc: linux-gpio@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/stm32/pinctrl-stm32f429.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) Thanks for the patch: Acked-by: Maxime Coquelin Regards, Maxime